-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Navbar #33
Added Navbar #33
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @Palaksharma23. Please consider following points:
- Side drawer would look better as for down header it is going through the header ununiformly.
- Provide cursor=pointer on hover.
- It would be better to show down arrow for dropdown in this case, also dropdown inside header is is not working for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @Palaksharma23, you have completely removed the sliding effect. also, the down arrow for dropdown is not yet visible. No one would be able to predict that it's a dropdown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Palaksharma23 LGTM:)
No description provided.